Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Feedback Widget issues #13513

Closed
3 tasks done
pdziugas opened this issue Aug 29, 2024 · 9 comments · Fixed by #13702
Closed
3 tasks done

User Feedback Widget issues #13513

pdziugas opened this issue Aug 29, 2024 · 9 comments · Fixed by #13702

Comments

@pdziugas
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/angular

SDK Version

8.27.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

Sentry.feedbackIntegration({
    colorScheme: 'light',
    enableScreenshot: true,
    ...
})

Steps to Reproduce

The issue here is that using the light color scheme inside the feedback integration and adding a darker color for --actor-background is enough to break the contrast of the icon shown in the widget__actor button.

#sentry-feedback {
    --actor-color: #fff !important;
    --actor-background: #0d5788 !important;
    ...
}

Image

The problem is that changing the --foreground color to a lighter one also changes the content inside the modal, causing it to be messed up. There should be a way to change the color or icon itself, or even remove it altogether.


Another issue is that modal content seems to be messed up on screens (600px or less) where the modal is opened and takes up full device screen

Image

Expected Result

I'd expect for an easy change for the icon color or maybe the icon itself. Expected result:

Image

Actual Result

Image
Image

@github-actions github-actions bot added the Package: angular Issues related to the Sentry Angular SDK label Aug 29, 2024
@andreiborza
Copy link
Member

Hi, thank you for the valuable feedback and improvement suggestions! These all seem very reasonable to me.

cc @billyvg

@c298lee
Copy link
Member

c298lee commented Sep 16, 2024

HI @pdziugas! A PR is up to fix the feedback icon issue. Once it's released, actor-color will also apply to the feedback icon.
How did you get into the state where the feedback modal looks like that on small screens? Through my own testing using Chrome dev tools and using the widget on a mobile device, it looks as expected to me.

@pdziugas
Copy link
Author

hey, @c298lee. Thanks! I'm not sure to be honest regarding the modal. Haven't made any changes to that, Looks exactly the same on my phone. The .form class seems to mess the alignment up

Image

@andreiborza
Copy link
Member

hi @pdziugas, do you have a reproduction repo for this?

@pdziugas
Copy link
Author

Hello, @andreiborza, I've created a new repo here which has the same issue reproduced. Thanks!

@andreiborza
Copy link
Member

@pdziugas thanks, taking a look!

@billyvg billyvg added Feature: User Feedback and removed Package: angular Issues related to the Sentry Angular SDK labels Sep 17, 2024
@c298lee c298lee reopened this Sep 17, 2024
@c298lee
Copy link
Member

c298lee commented Sep 17, 2024

@pdziugas Thanks for the repo! This PR should fix the modal issues, and should be out in the next SDK release. Let us know if you encounter anymore issues!

@pdziugas
Copy link
Author

@c298lee That will be it for now, thank you :)

@AbhiPrasad
Copy link
Member

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the GH issue @pdziugas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants