Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"heartbeatInterval" not availble in browser tracing integration #14805

Open
3 tasks done
rodolfoBee opened this issue Dec 19, 2024 · 2 comments · May be fixed by getsentry/sentry-docs#12194
Open
3 tasks done

"heartbeatInterval" not availble in browser tracing integration #14805

rodolfoBee opened this issue Dec 19, 2024 · 2 comments · May be fixed by getsentry/sentry-docs#12194
Labels
Package: browser Issues related to the Sentry Browser SDK Waiting for: Product Owner

Comments

@rodolfoBee
Copy link
Member

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/browser

SDK Version

8.47.0

Framework Version

No response

Link to Sentry event

No response

Reproduction Example/SDK Setup

NA

Steps to Reproduce

Follow the steps on this page to set heartbeatInterval in the browser tracing or react-router integrations

Expected Result

The option exists in the SDK.

Actual Result

The option is not defined in the SDK code: https://github.com/getsentry/sentry-javascript/blob/develop/packages/browser/src/tracing/browserTracingIntegration.ts

searching the repository for this option also does not return any results (other than a commented test).

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 19, 2024
@github-actions github-actions bot added the Package: browser Issues related to the Sentry Browser SDK label Dec 19, 2024
@mydea
Copy link
Member

mydea commented Dec 20, 2024

The heartbeatInterval option was removed in v8, we apparently forgot to update the docs accordingly.

There are:

  • idleTimeout
  • finalTimeout
  • childSpanTimeout

instead today. I'll update the docs for this!

@rk-1203
Copy link

rk-1203 commented Dec 25, 2024

@mydea Going forward is childSpanTimeout the direct replacement for heartbeatInterval? Or if not, how should the consumer app change their logic to consider this removal of heartbeatInterval parameter?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: browser Issues related to the Sentry Browser SDK Waiting for: Product Owner
Projects
Status: Waiting for: Product Owner
Development

Successfully merging a pull request may close this issue.

3 participants