Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds SAGP as an experimental expo plugin feature #4440

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Adds SAGP as an experimental expo plugin feature #4440

wants to merge 6 commits into from
+269 −1

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 13, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds SAGP as an experimental expo plugin when the sentryAndroidGradlePluginVersion is provided in the experimental_android section of the @sentry/react-native/expo plugin.
The supported options are the following:

  • autoUploadProguardMapping
  • includeProguardMapping
  • dexguardEnabled
  • uploadNativeSymbols
  • autoUploadNativeSymbols
  • includeNativeSources
  • includeSourceContext
  • autoInstallationEnabled

💡 Motivation and Context

Fixes #4400

💚 How did you test it?

CI, Manual testing:

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

See getsentry/sentry-android-gradle-plugin#809

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4e0e78f

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.98 ms 1234.84 ms 8.86 ms
Size 3.19 MiB 4.25 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ddc0552+dirty 1246.00 ms 1241.98 ms -4.02 ms
8de2810+dirty 1238.15 ms 1236.31 ms -1.84 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
eb1e19f+dirty 1229.91 ms 1231.63 ms 1.71 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
13f280b+dirty 1217.73 ms 1229.08 ms 11.35 ms
1faf8e3+dirty 1223.38 ms 1220.56 ms -2.82 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
d8e8c67+dirty 1235.58 ms 1233.44 ms -2.15 ms
fe13591+dirty 1250.69 ms 1246.27 ms -4.43 ms

App size

Revision Plain With Sentry Diff
ddc0552+dirty 2.92 MiB 3.67 MiB 772.47 KiB
8de2810+dirty 2.92 MiB 3.66 MiB 756.74 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
eb1e19f+dirty 2.92 MiB 3.64 MiB 742.82 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
13f280b+dirty 2.92 MiB 3.66 MiB 758.67 KiB
1faf8e3+dirty 2.92 MiB 3.64 MiB 742.61 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
d8e8c67+dirty 2.92 MiB 3.69 MiB 790.53 KiB
fe13591+dirty 2.92 MiB 3.66 MiB 757.71 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.37 ms 1242.12 ms 9.75 ms
Size 2.63 MiB 3.68 MiB 1.05 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ddc0552+dirty 1236.13 ms 1248.17 ms 12.05 ms
8de2810+dirty 1230.84 ms 1226.35 ms -4.49 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
eb1e19f+dirty 1209.56 ms 1214.94 ms 5.38 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
13f280b+dirty 1229.25 ms 1226.10 ms -3.15 ms
1faf8e3+dirty 1214.87 ms 1222.83 ms 7.97 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
d8e8c67+dirty 1222.57 ms 1226.22 ms 3.65 ms
fe13591+dirty 1208.25 ms 1219.53 ms 11.28 ms

App size

Revision Plain With Sentry Diff
ddc0552+dirty 2.36 MiB 3.11 MiB 759.84 KiB
8de2810+dirty 2.36 MiB 3.10 MiB 752.30 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
eb1e19f+dirty 2.36 MiB 3.08 MiB 737.21 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
13f280b+dirty 2.36 MiB 3.10 MiB 753.43 KiB
1faf8e3+dirty 2.36 MiB 3.08 MiB 736.75 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
d8e8c67+dirty 2.36 MiB 3.12 MiB 779.40 KiB
fe13591+dirty 2.36 MiB 3.10 MiB 752.40 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 410.49 ms 464.94 ms 54.45 ms
Size 7.15 MiB 8.38 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
43e66e0+dirty 378.20 ms 404.59 ms 26.40 ms
e22745e+dirty 415.50 ms 448.76 ms 33.26 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
70e6261+dirty 395.08 ms 408.12 ms 13.04 ms
9f0f6c8+dirty 365.53 ms 419.16 ms 53.63 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms

App size

Revision Plain With Sentry Diff
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
43e66e0+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e22745e+dirty 7.15 MiB 8.35 MiB 1.20 MiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
70e6261+dirty 7.15 MiB 8.21 MiB 1.07 MiB
9f0f6c8+dirty 7.15 MiB 8.37 MiB 1.22 MiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 459.71 ms 465.70 ms 5.99 ms
Size 17.75 MiB 20.11 MiB 2.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d7401ac+dirty 375.20 ms 383.51 ms 8.31 ms
ac41368 451.47 ms 453.67 ms 2.20 ms
946a600 384.53 ms 366.65 ms -17.88 ms
8b86336 424.98 ms 413.06 ms -11.92 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
1c65324 426.37 ms 460.36 ms 33.99 ms
d16beca 448.87 ms 447.20 ms -1.67 ms
8ab11b6 462.10 ms 450.40 ms -11.70 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
a989877 425.71 ms 411.04 ms -14.67 ms

App size

Revision Plain With Sentry Diff
d7401ac+dirty 17.73 MiB 19.75 MiB 2.02 MiB
ac41368 17.73 MiB 20.11 MiB 2.38 MiB
946a600 17.74 MiB 20.09 MiB 2.35 MiB
8b86336 17.75 MiB 20.11 MiB 2.36 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
1c65324 17.73 MiB 19.95 MiB 2.21 MiB
d16beca 17.74 MiB 20.10 MiB 2.36 MiB
8ab11b6 17.74 MiB 20.09 MiB 2.35 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
a989877 17.74 MiB 20.07 MiB 2.34 MiB

@antonis antonis marked this pull request as ready for review January 14, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proguard Mappings are not uploaded using expo plugin
1 participant
@antonis