Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReactNavigation] Name navigation spans using dispatched action data #4429

Open
krystofwoldrich opened this issue Jan 9, 2025 · 1 comment

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Jan 9, 2025

The ReactNavigationIntegration doesn't read dispatch action data and starts generic Route Changed navigation span on every dispatch.

Depending on the action type the new route name can be specified in the data. For example navigation action has name of the new route in it's payload. This might not be the final route as that depends on the router processing the action.

Using the data from the dispatched action will reduce the number of Route Changed spans. We should still update the name once the router processed the action with the final route name.


current integration implementation
react-navigation onDispatch implementation
poc branch


Related Issue: not all actions are expected to trigger navigation

@krystofwoldrich
Copy link
Member Author

We need to ensure adding this doesn't break support for ReactNavigation V5 and V6.

@krystofwoldrich krystofwoldrich moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant