Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue details: Expand thread-scoped data #82865

Open
bruno-garcia opened this issue Jan 3, 2025 · 2 comments
Open

Issue details: Expand thread-scoped data #82865

bruno-garcia opened this issue Jan 3, 2025 · 2 comments

Comments

@bruno-garcia
Copy link
Member

Problem Statement

Today, a partner sending data for native crashes has a series of Thread-scoped data.

For example:

key value
affinity_mask 0x0000000000000007
current_core 1
exception_address 0x0000000000000000
exception_code 2
exception_code_description Access Violation Data
exception_thread 355925
ideal_core 1
lr_called true
priority 15
stack_bottom 0x0000006a07a7b390
stack_top 0x0000006a07b7b390

Currently, they send this via threads.stacktrace[i].vars, which is displayed under the frame, e.g:

Image

Ideally this data is displayed outside the stack trace, but within the scope of the thread. So when the thread selector is used, the values get updated.

Solution Brainstorm

Today, the Thread part of the protocol has a few fields, some specialized, but also a generic field: other for unknown top level fields to be kept and support forward compatibility

https://github.com/getsentry/relay/blob/fe3f09fd3accd2361887dd678dbe034f25139fce/relay-event-schema/src/protocol/thread.rs#L213-L249

Could we use the other field? Or should we add a specialized map?

Is other already displayed somewhere?

The current design would indicate values should be shown in this tag-like UI:
Image

Is there a way to pass values to be added there outside of the exception interface?

Product Area

Issues

@getsantry
Copy link
Contributor

getsantry bot commented Jan 3, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@lobsterkatie
Copy link
Member

I'll bring this to the attention of the folks working on improving the issue details page, to see what they say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants