Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully unit test (de)serialize functions in blocks #130

Open
ibokuri opened this issue Aug 5, 2023 · 0 comments
Open

Fully unit test (de)serialize functions in blocks #130

ibokuri opened this issue Aug 5, 2023 · 0 comments
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.

Comments

@ibokuri
Copy link
Contributor

ibokuri commented Aug 5, 2023

For example, duplicate fields during deserialization should return error.DuplicateField.

This includes errors from attributes. For example, renaming a field and then not correctly having that field in the input data should return an UnknownVariant or MissingField or whatever.
@ibokuri ibokuri added improvement proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. and removed improvement proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ibokuri