Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Handling of unknown engines #24

Closed
2 tasks done
airnst opened this issue Nov 19, 2024 · 0 comments · Fixed by #30
Closed
2 tasks done

[FEATURE] Handling of unknown engines #24

airnst opened this issue Nov 19, 2024 · 0 comments · Fixed by #30
Assignees
@airnst
Labels
enhancement New feature or request index.php service: transform

Comments

@airnst
Copy link
Collaborator

airnst commented Nov 19, 2024 •
edited
Loading

Description

In the index.json files, engines are specified for the respective transformation. If the engine is unknown to the DTS then this case must be handled by logging and returning an error message to the client.

Files

index.php

Tasks

  • Implement unknown engine handling.
  • Test through adjusted index.json files.
@airnst airnst self-assigned this Nov 19, 2024
airnst pushed a commit that referenced this issue Nov 20, 2024
[#24] Added error logging and response.
74bc4b0
airnst pushed a commit that referenced this issue Nov 21, 2024
[#24] Added result folder removal. Code cleanup.
ac10fa6
@airnst airnst linked a pull request Dec 17, 2024 that will close this issue
[#24] Handling of unknown engines #30
Merged
@airnst airnst mentioned this issue Dec 17, 2024
Merged
airnst added a commit that referenced this issue Jan 14, 2025
@airnst
Merge pull request #30 from gfbio/24-feature-handling-of-unknown-engines
e3031a1 
[#24] Handling of unknown engines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@airnst airnst

Labels
enhancement New feature or request index.php service: transform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#24] Handling of unknown engines gfbio/data-transformation-service
1 participant
@airnst