Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTLCaptureDescriptor #153

Closed
chinedufn opened this issue Jul 5, 2020 · 3 comments
Closed

MTLCaptureDescriptor #153

chinedufn opened this issue Jul 5, 2020 · 3 comments

Comments

@chinedufn
Copy link
Collaborator

Methods on the MTLCaptureManager such as startCaptureWithDevice are deprecated in Metal in favor of using an MTLCaptureDescriptor, which does not currently exist in metal-rs.

Example deprecation -> https://developer.apple.com/documentation/metal/mtlcapturemanager/2869714-startcapture
@chinedufn
Copy link
Collaborator Author

This is a blocker to #152 since there is currently no way to set the .gpuTrace output file since there is no capture descriptor.

@chinedufn chinedufn mentioned this issue Jul 5, 2020
Merged
@kvark
Copy link
Member

kvark commented Jul 6, 2020

Interesting! This is macOS 10.15 though, so we shouldn't remove the old stuff just yet.

bors bot added a commit that referenced this issue Jul 11, 2020
@bors @chinedufn
Merge #155
d75c1a6 
155: Add CaptureDescriptor r=kvark a=chinedufn

This PR adds the `CaptureDescriptor`, closing #153 

Co-authored-by: Chinedu Francis Nwafili <[email protected]>
@chinedufn
Copy link
Collaborator Author

Closed by #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @chinedufn