Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX not affected by region feature of the V12 #726

Open
Dolgrenn opened this issue Jun 26, 2024 · 4 comments
Open

FX not affected by region feature of the V12 #726

Dolgrenn opened this issue Jun 26, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Dolgrenn
Copy link

Expected Behavior

FX should be blocked by the region I created

Current Behavior

the FX still appear in the region I created to block them

Steps to Reproduce

  1. Create a region using the tool integrated into v12
  2. activate the region option blocking FX
  3. activate an effect on the current scene

Context

No response

Version

v4.0.2

Foundry VTT Version

v12

Operating System

windows

Browser / App

Other

Game System

Vaesen

Relevant Modules

No response

@Dolgrenn Dolgrenn added bug Something isn't working to be confirmed labels Jun 26, 2024
@ghost91-
Copy link
Contributor

V12 is not supported yet, see #718

@Aioros
Copy link
Contributor

Aioros commented Aug 6, 2024

Assuming that everything goes well with the v12 update, I think that this is going to be the most requested feature. An easy start would be to treat "Suppress Weather" regions just like mask drawings, and that doesn't seem too difficult (I might have a PR basically ready), but I wonder if there's any interest in creating a custom region type for that. The behavior of the region could even define the specific particle effect for that region, if masking individual particle effects is still a desired feature.

@ghost91- ghost91- added enhancement New feature or request confirmed and removed bug Something isn't working to be confirmed confirmed labels Sep 8, 2024
@ghost91- ghost91- reopened this Sep 8, 2024
@ghost91- ghost91- added the help wanted Extra attention is needed label Sep 8, 2024
@ghost91-
Copy link
Contributor

ghost91- commented Sep 8, 2024

@Aioros I agree, this is likely a desired feature and should eventually just replace the drawing mask functionality all together. As a first step, just supporting the "Suppress Weather" regions sounds like a decent idea. Unfortunately, I currently don't have the capacity to do that. Feel free to create a PR, though.

@Nedrapter
Copy link

Experiencing this as well, I noticed that if the effect is added from the Scene's configuration, it does get supressed. However this way you can't add multiple effects and it's also not convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants