Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mount_be with path and add return bectl path #5

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Improve mount_be with path and add return bectl path #5

merged 2 commits into from
Jul 4, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jul 4, 2024 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Enhanced the 'mount_be' function in 'bectl.py' by adding an optional 'path' parameter for specifying the mount location and updated the function to return the mount path.

  • New Features:
    • Added an optional 'path' parameter to the 'mount_be' function to specify the mount location.
  • Enhancements:
    • Updated 'mount_be' function to return the path where the BE is mounted.

@ericbsd ericbsd requested review from a team July 4, 2024 01:36
@ericbsd ericbsd self-assigned this Jul 4, 2024
@ericbsd ericbsd linked an issue Jul 4, 2024 that may be closed by this pull request
Add support to mount and unmount BE to pybectl. ghostbsd/issues#160
Closed
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jul 4, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request enhances the mount_be function in bectl.py by adding support for an optional path parameter where the BE will be mounted. If the path is not provided, a random one will be created by bectl. Additionally, the function now returns the path where the BE is mounted. The docstring has been updated to reflect these changes, and the run function call has been modified to include universal_newlines and encoding parameters.

File-Level Changes

Files Changes
bectl.py Enhanced the mount_be function to support an optional mount path and to return the mount path.
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 4, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

bectl.py Show resolved Hide resolved
bectl.py Show resolved Hide resolved
bectl.py Show resolved Hide resolved
bectl.py Show resolved Hide resolved
@ericbsd ericbsd merged commit fd71b2f into master Jul 4, 2024
@ericbsd ericbsd deleted the 160-add-support-to-mount-and-unmount-be-to-pybectl branch July 4, 2024 10:45
@ericbsd ericbsd added the enhancement New feature or request label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai Sourcery AI Sourcery AI left review comments

Assignees

@ericbsd ericbsd

Labels
enhancement New feature or request
Projects
Development Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to mount and unmount BE to pybectl.
1 participant
@ericbsd