Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The future of "messages" and unmatched interaction events #218

Open
ghostdevv opened this issue Nov 8, 2024 · 0 comments
Open

The future of "messages" and unmatched interaction events #218

ghostdevv opened this issue Nov 8, 2024 · 0 comments
Labels
needs shaping More information needed / Decision needs making
Milestone

Comments

@ghostdevv
Copy link
Owner

ghostdevv commented Nov 8, 2024

Currently we have the messages feature which just includes a message for unknownCommand. JellyCommands sends this message when the command it receives isn't known. This is a reasonable assumption, since JellyCommands requires to be the sole command registrar. However, it's still weird because if that assumption is right then it shouldn't ever happen right? The times I've come into it is partially due to development quirks and partly due to #216 (us matching by id, rather than name).

Currently my ideas around this are:

  • Remove messages and happily ignore any command interactions we don't handle. We should also warn in console if this happens.
  • Provide a "catchall" hook that you can modify to customise the behaviour when this happens. The default hook would replicate the current behaviour, minus an option to configure the "messages"

Similarly we need to decide what happens to other interactions that suffer this problem, and whether it exists. I can imagine there being situations where you have a button/modal/etc request that comes in we can't handle. Now whether that's because of a typo, or you receive interactions from other bots (I don't believe so), not sure. Needs investigating

@ghostdevv ghostdevv added the enhancement New feature or request label Nov 8, 2024
@ghostdevv ghostdevv added this to the v1 milestone Nov 8, 2024
@ghostdevv ghostdevv added needs shaping More information needed / Decision needs making and removed enhancement New feature or request labels Nov 10, 2024
@ghostdevv ghostdevv changed the title Remove messages The future of "messages" and unmatched interaction events Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs shaping More information needed / Decision needs making
Projects
None yet
Development

No branches or pull requests

1 participant