Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor documentation #4018

Open
chrmod opened this issue Jun 10, 2024 · 0 comments
Open

Preprocessor documentation #4018

chrmod opened this issue Jun 10, 2024 · 0 comments

Comments

@chrmod
Copy link
Member

chrmod commented Jun 10, 2024

We need a proper high-level description of preprocessors and their role in the adblocker library.
Comments like https://github.com/ghostery/adblocker/pull/4016/files#diff-6bbed6f2ce82ce3e568015ed0042560e15d069e1ad2735edbba1dc1046780de6R445 are not easy to understand from the newcomer perspective.

Need to think where is the best place to describe the setup and its details.

We can start with something like Preprocessors are a layer on top of FiltersEngine to exclude some filters at runtime based on conditions from the environment but they don't change which filters are in the FiltersEngine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants