gtk-libadwaita vs gtk-adwaita

[jcollie]

In build.zig the gtk-libadwaita build option is defined:

ghostty/build.zig

Lines 94 to 98 in d47df21

	config.libadwaita = b.option(
	bool,
	"gtk-libadwaita",
	"Enables the use of libadwaita when using the gtk rendering backend.",
	) orelse true;

In src/config/Config.zig a config option named gtk-adwaita is defined:

ghostty/src/config/Config.zig

Lines 1626 to 1638 in d47df21

	/// If `true` (default), Ghostty will enable libadwaita theme support. This
	/// will make `window-theme` work properly and will also allow Ghostty to
	/// properly respond to system theme changes, light/dark mode changing, etc.
	/// This requires a GTK4 desktop with a GTK4 theme.
	///
	/// If you are running GTK3 or have a GTK3 theme, you may have to set this
	/// to false to get your theme picked up properly. Having this set to true
	/// with GTK3 should not cause any problems, but it may not work exactly as
	/// expected.
	///
	/// This configuration only has an effect if Ghostty was built with
	/// libadwaita support.
	@"gtk-adwaita": bool = true,

I find it slightly annoying that these are named differently, what do people think about renaming one or the other so that they are the same?

[mitchellh]

I'm good with this. I won't create an issue since this is so trivial and I have a feeling you're going to do it quickly. 😄 But go ahead and lets make that breaking change before the 1.0 release.