Another case of fish shell integration not working on macOS

[wzxu]

Related: #2484

In my case, $GHOSTTY_SHELL_INTEGRATION_XDG_DIR is defined but it's not prepended to $XDG_DATA_DIRS.

If I manually prepend the path then shell integration will work.

I suspected my fish being installed by Nix may have something to do with it,
but I just tried to install and chsh my shell to Homebrew fish and it's still the same.

OS: macOS Sonoma 14.6.1 arm64
Shell: fish 3.7.1 ($SHELL = /run/current-system/sw/bin/fish)
Terminal: ghostty 0.1.0-main+9472853f

Here's the log stream:

Filtering the log data using "subsystem == "com.mitchellh.ghostty""
Timestamp                       Thread     Type        Activity             PID    TTL  
2024-11-17 09:36:51.012392+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] ghostty version=0.1.0-main+9472853f
2024-11-17 09:36:51.012478+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] ghostty build optimize=ReleaseFast
2024-11-17 09:36:51.012494+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] runtime=apprt.Runtime.none
2024-11-17 09:36:51.012502+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] font_backend=font.main.Backend.coretext
2024-11-17 09:36:51.012510+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] renderer=renderer.Metal
2024-11-17 09:36:51.012517+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] libxev backend=main.Backend.kqueue
2024-11-17 09:36:51.012603+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:os] detected system locale=en_TW.UTF-8
2024-11-17 09:36:51.012861+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:os] setlocale after unset lang result=C
2024-11-17 09:36:51.012876+0800 0x77d263   Error       0x0                  11147  0    ghostty: [com.mitchellh.ghostty:os] setlocale failed with LANG and system default. Falling back to en_US.UTF-8
2024-11-17 09:36:51.013276+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:os] setlocale default result=en_US.UTF-8
2024-11-17 09:36:51.023026+0800 0x77d272   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:sentry] sentry envelope does not contain crash, discarding
2024-11-17 09:36:51.079888+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:default] reading configuration file path=/Users/wzxu/.config/ghostty/config
2024-11-17 09:36:51.080230+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:config] default shell src=passwd value=/run/current-system/sw/bin/fish
2024-11-17 09:36:51.080250+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:config] default working directory src=passwd value=/Users/wzxu
2024-11-17 09:36:51.134051+0800 0x77d263   Debug       0x0                  11147  0    ghostty: [com.mitchellh.ghostty:AppDelegate] application will restore window state
2024-11-17 09:36:51.134856+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:ghostty] known but unimplemented action action=29
2024-11-17 09:36:51.140075+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:font_shared_grid_set] font regular: InputMonoCondensed Nerd Font
2024-11-17 09:36:51.140933+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:font_shared_grid_set] font bold: InputMonoCondensed Nerd Font Bold
2024-11-17 09:36:51.142226+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:font_shared_grid_set] font italic: InputMonoCondensed Nerd Font Italic
2024-11-17 09:36:51.143194+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:font_shared_grid_set] font bold_italic: InputMonoCondensed Nerd Font Bold Italic
2024-11-17 09:36:51.147111+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:io_exec] found Ghostty resources dir: /Applications/Ghostty.app/Contents/Resources/ghostty
2024-11-17 09:36:51.147145+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:io_exec] shell integration automatically injected shell=termio.shell_integration.Shell.fish
2024-11-17 09:36:51.147727+0800 0x77d263   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:ghostty] known but unimplemented action action=16
2024-11-17 09:36:51.148812+0800 0x77d279   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:io_exec] started subcommand path=/usr/bin/login pid=11148
2024-11-17 09:36:51.844369+0800 0x77d278   Info        0x0                  11147  0    ghostty: [com.mitchellh.ghostty:font_codepoint_resolver] found codepoint 0x2714 in fallback face=Menlo Regular
2024-11-17 09:37:05.037297+0800 0x77d263   Debug       0x0                  11147  0    ghostty: [com.mitchellh.ghostty:AppDelegate] application will save window state

[mitchellh]

I wonder if this is caused by going through a login shell on macOS.

[mitchellh]

In my case, it looks like Nix is setting up a login script that is resetting XDG_DATA_DIRS. Since on macOS terminals open up as a login shell in EVERY instance, this is clearing it out in every instance. I don't think there is anything Ghostty can or should particularly do about this.

[jparise]

That's recent-enough to include those changes. I don't actively use nix or zsh myself so hopefully someone else can provide some more insight.

[isker]

This is about fish, not zsh. Like most, I'm a pretty hapless user of nix, but I'll try grepping really hard 🌞 and report back if I find a solution. This is my current candidate.

[isker]

Yes, adding this to my nix-darwin config seems to make everything work:

  # Hack: https://github.com/ghostty-org/ghostty/discussions/2832
  environment.variables.XDG_DATA_DIRS = ["$GHOSTTY_SHELL_INTEGRATION_XDG_DIR"];

I had struggled for a bit because I forgot nix will merge that definition of XDG_DATA_DIRS with the one in nix-darwin; they do not conflict.

[charlottia]

Unsure if I'm adding anything useful here, but I'm also using Nix and fish on macOS, and found that shell integration isn't working on the official 1.0.0 build, but on a build of current main (6cbd69d) works perfectly without any other changes.

I just tried building the v1.0.0 tag myself in case it was just a build environment thing, and it doesn't work! So curiosity has officially struck and I'm going to see where bisect lands me :3

[charlottia]

… okay, turns out that wasn't it 😅 False alarm! I'm more confused than I thought I was. (thirty bisect builds later …)

Using open /Applications/Ghostty.app (e.g. from the builtin Terminal) actually results in shell integration working fine in v1.0.0, and so likewise did open macos/build/ReleaseLocal/Ghostty.app.

It does look to be exactly the above issue; unsetting __NIX_DARWIN_SET_ENVIRONMENT_DONE with env -u __NIX_DARWIN_SET_ENVIRONMENT_DONE open macos/build/ReleaseLocal/Ghostty.app gives rise to the issue again, whereas letting it propagate means Nix won't mess with XDG_DATA_DIRS.

Sorry for the noise!