Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt5 compatibility status? #10

Open
nehbit opened this issue Jun 9, 2013 · 3 comments
Open

Qt5 compatibility status? #10

nehbit opened this issue Jun 9, 2013 · 3 comments

Comments

@nehbit
Copy link

nehbit commented Jun 9, 2013

Are there any reports on compatibility of this reactor with Qt5?

I've got this reactor to run without problems on Qt4, but performance of QtWebKit in Qt4 vs Qt5 (12s per page load vs 300ms per page load) is forcing my hand to switch to Qt5. Qt4 and Qt5 are largely compatible, is there anybody who tried such a thing?

And of course, thanks for single–handedly maintaining this. I really appreciate it.

@ghtdak
Copy link
Owner

ghtdak commented Sep 24, 2014

Next on the list

@nehbit
Copy link
Author

nehbit commented Sep 25, 2014

Hey Glenn,

I actually went ahead and got it ported to Qt5. It passes the test suite and I have been stress testing it fairly heavily since the last year as one of the core components of Aether and I never had any problems. You can see it here: https://github.com/nehbit/aether-public/blob/master/qt5reactor.py

The changes you have to make are fairly minimal. Let me know if you need my help. I can also do a pull request, but it's so small I think you could just lift it from the link.

@ghtdak
Copy link
Owner

ghtdak commented Sep 25, 2014

On Wed, Sep 24, 2014 at 10:03 PM, Burak Nehbit [email protected]
wrote:

I actually went ahead and got it ported to Qt5. It passes the test suite
and I have been stress testing it fairly heavily since the last year as one
of the core components of Aether http://www.getaether.net and I never
had any problems. You can see it here:
https://github.com/nehbit/aether-public/blob/master/qt5reactor.py

Wow, very cool.

The changes you have to make are fairly minimal. Let me know if you need
my help. I can also do a pull request, but it's so small I think you could
just lift it from the link.

Yup.

I'm, ever more carefully, now, going through the internals one last time.
Very tricky business... Particularly the socket notifier stuff. You might
want to take the latest, its cleaner but I don't know if it matters all
that much. Or wait a while. I'm probably going to tease out some last
bits.

One can go blind looking at things like the kqueue implementations.

Glenn H. Tarbox, PhD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants