Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing local netpbm binaries and libraries #169

Open
onlyjob opened this issue May 5, 2021 · 1 comment
Open

removing local netpbm binaries and libraries #169

onlyjob opened this issue May 5, 2021 · 1 comment

Comments

@onlyjob
Copy link
Contributor

onlyjob commented May 5, 2021

Please consider to remove redundant binary executables and libraries from "netpbm" package.
For some reasons binaries are referenced in https://github.com/gigablast/open-source-search-engine/blob/master/Process.cpp#L161

It is the best to avoid committing prebuilt binaries to the repository. Thanks.

@onlyjob
Copy link
Contributor Author

onlyjob commented May 6, 2021

Of several "netpbm" binaries, bmptopnm, pngtopnm, tifftopnm and giftopnm are used only in Process.cpp to ensure their presence in gb's data(!) folder. This is unconventional and PATH should work just fine.

Only the following are actually used:

  • ppmtojpeg
  • pnmscale
  • jpegtopnm

IMHO it should be safe to remove all those utilities from the repository and especially from Process.cpp so admins could use newer (updateable) package from the Operating System.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant