You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Of several "netpbm" binaries, bmptopnm, pngtopnm, tifftopnm and giftopnm are used only in Process.cpp to ensure their presence in gb's data(!) folder. This is unconventional and PATH should work just fine.
Only the following are actually used:
ppmtojpeg
pnmscale
jpegtopnm
IMHO it should be safe to remove all those utilities from the repository and especially from Process.cpp so admins could use newer (updateable) package from the Operating System.
Please consider to remove redundant binary executables and libraries from "netpbm" package.
For some reasons binaries are referenced in https://github.com/gigablast/open-source-search-engine/blob/master/Process.cpp#L161
It is the best to avoid committing prebuilt binaries to the repository. Thanks.
The text was updated successfully, but these errors were encountered: