Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for downloading chromedriver at runtime #256

Open
HaimBendanan opened this issue Mar 25, 2020 · 7 comments
Open

Support for downloading chromedriver at runtime #256

HaimBendanan opened this issue Mar 25, 2020 · 7 comments

Comments

@HaimBendanan
Copy link

Hey, thanks for this very useful repo.
In my use case, I am shipping an app that uses the chrome driver, so I need to handle cases where users have different chrome versions, and where they update chrome once in a while.
I ended up calling the install script every time my app start, to install the appropriate chrome version
Would be great if it was a built in functionality (I had to do some workarounds to make it works)
What do you think about it?

@giggio
Copy link
Owner

giggio commented Apr 4, 2020

Yes, it could be done. We'd only have to add a download function to lib/chromedriver.js. I'm open to a PR.

@chbota
Copy link

chbota commented Sep 8, 2020

I've run into a scenario where I think I'd need this functionality. Just a heads up that I'm going to try to get a PR together over the next few days and send it out for feedback 😄

@r3pwn
Copy link

r3pwn commented Sep 24, 2020

@chbota I have done the work required for this issue in PR #278, but it is awaiting review :)

@chbota
Copy link

chbota commented Sep 24, 2020

Even better! Thanks for the heads up 😄

@bhuber2010
Copy link

@giggio what's the plan on this? I saw the PR went stale. Seemed rather minor of a change really. Being able to call the install outside of the node require to actually wait for it to finish would be huge!

@giggio
Copy link
Owner

giggio commented Mar 4, 2021

@bhuber2010 it went stale because it was a large change and I couldn't review it. If you are able to provide a localized update I'm willing to look into it.

@niehusst
Copy link

niehusst commented Nov 7, 2021

I opened a new PR for this issue that is exactly the same as @r3pwn 's original PR but without the large refactors that made it hard for @giggio to review.
#332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants