Data Attribute for Step #1018
Closed
fredericbahr
started this conversation in
Ideas
Replies: 1 comment
-
Hey @fredericbahr |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey,
first of all, great library!
Is it possible to add a data attribute to a step definition allowing the consumer/user of the library to provide arbitrary data which can be accessed in the joyride callback.
I think this would simplify custom use cases like multiroute navigation or actions which should be done before/after a step.
Additionally it enables a clear sepearation of concerns and a strict place where information is defined.
In your multiroute example the navigation/routing information is defined within the callback, but each step information is defined in a separate data structure.
After the change, the callback is truly responsible for managing the tour and state of joyride but does not provide additional information for a step.
Example:
Inside the callback one has access to the step definition (which in fact is great API-Design) and can react on the data provided.
Example:
If you need help implementing this, let me know. I will look how much spare time i can use to help you.
Beta Was this translation helpful? Give feedback.
All reactions