Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for swift package manager #212

Open
yzfr6 opened this issue Nov 30, 2020 · 7 comments
Open

Support for swift package manager #212

yzfr6 opened this issue Nov 30, 2020 · 7 comments

Comments

@yzfr6
Copy link

yzfr6 commented Nov 30, 2020

Please add a the swift package manifest to allow us to import this package via Xcode's mechanism

@floriangbh
Copy link

I'm also looking for this to drop Cocoapods !

@vincentthe0ne
Copy link

I've added SPM Support in a fork of this project -> https://github.com/worldiety/Swift-YouTube-Player.
I've also created a Merge Request #215 for that issue. It's tested through the command line swift test and I've also set up a Test Project (incl. SwiftUI) to prove that It is working (https://github.com/vincentthe0ne/SPMYouTubePlayerTest).

@jalian37
Copy link

I've added SPM Support in a fork of this project -> https://github.com/worldiety/Swift-YouTube-Player.
I've also created a Merge Request #215 for that issue. It's tested through the command line swift test and I've also set up a Test Project (incl. SwiftUI) to prove that It is working (https://github.com/vincentthe0ne/SPMYouTubePlayerTest).

I have tried to link the fork into my Xcode 12.5.1 SPM, but the issue is the same, any suggestions please?

@vincentthe0ne
Copy link

Hey @jalian37 could you provide any more details? What issue occurs?

@jalian37
Copy link

Hey @jalian37 could you provide any more details? What issue occurs?

I have entered this url into SPM https://github.com/worldiety/Swift-YouTube-Player.git, and received the following error
image
I am doing this for the first time, so any suggestions are welcome. Thx!

@vincentthe0ne
Copy link

Ok! The Fork currently only has the old tags of the base Repository. So the 0.7.2 has no SPM Support. The Idea was, that hopefully the changes from the fork will soon be merged in the next version of this Repository (e.g. 0.7.3) hence in the future the origin Repository will be used instead of my fork.

Until that is the case, you need to set the Rules for the URL to "Branch" and then "Master". For now I can say, that I am (and my company also) have no intention in working actively on the fork, it's just a solution to integrate the Swift-Youtube-Player via SPM until the owner of this Repository merges the Pull Request into this project.

Hope I could help you.

@jalian37
Copy link

Ok! The Fork currently only has the old tags of the base Repository. So the 0.7.2 has no SPM Support. The Idea was, that hopefully the changes from the fork will soon be merged in the next version of this Repository (e.g. 0.7.3) hence in the future the origin Repository will be used instead of my fork.

Until that is the case, you need to set the Rules for the URL to "Branch" and then "Master". For now I can say, that I am (and my company also) have no intention in working actively on the fork, it's just a solution to integrate the Swift-Youtube-Player via SPM until the owner of this Repository merges the Pull Request into this project.

Hope I could help you.

Thank you! Problem solved :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants