Missing Diff Anotations?

[JacobJaffe]

First off, thanks for this action! Great to not have to pull in a separate service for a fast check.

I'm running a config for pull requests; this is giving a success / failure check, but isn't giving diff annotations. What's the expected behavior for this / is this not meant for PR config?

Also, in the EsLint Checks logs, the errors are not logged, only the count at the end:

...
 found 1377 vulnerabilities (1375 high, 2 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
1 error(s), 0 warning(s) found
##[error]Docker run failed with exit code 78

This would be much more helpful IMO if this also listed the errors.

my config:

name: Linter

on: [pull_request]

jobs:
  es-lint:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v1
    - name: ESLint checks
      uses: gimenete/[email protected]
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

[nomego]

Same here, https://github.com/Neovici/cosmoz-treenode/pull/17/checks?check_run_id=209140616

[nomego]

Solved this by creating another solution - https://github.com/Neovici/github-actions-eslint-annotator

This is installed as an npm dependency instead and added to the github workflow as a run step (see README), which avoids the need to spin up a node docker container (approx 30s).
Also I fixed the checks for PRs, and finally it won't fail the main workflow (since the new check will fail instead).

[exoRift]

I messaged the dev on Twitter. It doesn't work with YAML at the moment, but he's working on it

[exoRift]

This should probably be closed