From 5ea1f87e8838da6ff3d02435f979778342fe1af4 Mon Sep 17 00:00:00 2001
From: Ghost <zhan940842903@163.com>
Date: Wed, 4 Sep 2024 00:18:10 +0800
Subject: [PATCH] choer: change redirect note conetxt

---
 context.go      | 7 +++++++
 context_test.go | 1 +
 docs/doc.md     | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/context.go b/context.go
index baa4b0f9c9..ede8e69ee2 100644
--- a/context.go
+++ b/context.go
@@ -1066,7 +1066,14 @@ func (c *Context) String(code int, format string, values ...any) {
 }
 
 // Redirect returns an HTTP redirect to the specific location.
+// When the 'location' parameter is empty, it poses a potential security risk.
+// Avoid bringing potential security risks into the production environment.
 func (c *Context) Redirect(code int, location string) {
+	if location == "" {
+		debugPrint(`[WARNING] When the 'location' parameter is empty, it poses a potential security risk. Please input a secure redirection URL to ensure safe operation.`)
+	}
+
+
 	c.Render(-1, render.Redirect{
 		Code:     code,
 		Location: location,
diff --git a/context_test.go b/context_test.go
index 66190b302e..6900026531 100644
--- a/context_test.go
+++ b/context_test.go
@@ -1226,6 +1226,7 @@ func TestContextRenderRedirectAll(t *testing.T) {
 	assert.Panics(t, func() { c.Redirect(309, "/resource") })
 	assert.NotPanics(t, func() { c.Redirect(http.StatusMultipleChoices, "/resource") })
 	assert.NotPanics(t, func() { c.Redirect(http.StatusPermanentRedirect, "/resource") })
+	assert.NotPanics(t, func() { c.Redirect(http.StatusTemporaryRedirect, "")})
 }
 
 func TestContextNegotiationWithJSON(t *testing.T) {
diff --git a/docs/doc.md b/docs/doc.md
index b76011f2ab..414431df7e 100644
--- a/docs/doc.md
+++ b/docs/doc.md
@@ -1496,6 +1496,8 @@ Gin allow by default use only one html.Template. Check [a multitemplate render](
 
 Issuing a HTTP redirect is easy. Both internal and external locations are supported.
 
+Note: When the location is empty, there is a security risk. Please do not bring it to production
+
 ```go
 r.GET("/test", func(c *gin.Context) {
   c.Redirect(http.StatusMovedPermanently, "http://www.google.com/")