Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gb_mod is broken #47

Open
LiterallyVoid opened this issue Jun 3, 2021 · 0 comments
Open

gb_mod is broken #47

LiterallyVoid opened this issue Jun 3, 2021 · 0 comments

Comments

@LiterallyVoid
Copy link

LiterallyVoid commented Jun 3, 2021

gb_remainder uses round. this is bad, because it means gb_remainder(1.5, 2.0) = -0.5, and gb_mod(2.5, 2.0) = 2.5. this is contrary to how the C standard library modf / remainder functions work.

edit: it looks like gb_remainder is correct; but gb_mod is wrong.

@LiterallyVoid LiterallyVoid changed the title gb_remainder and gb_mod are broken gb_mod is broken Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant