Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for inline radio buttons & check boxes #106

Open
ssmithereens opened this issue May 11, 2021 · 7 comments
Open

Support for inline radio buttons & check boxes #106

ssmithereens opened this issue May 11, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@ssmithereens
Copy link
Contributor

ssmithereens commented May 11, 2021

This project is truly fantastic.

Are there any plans to support inline radio buttons and check boxes? We use these quite a bit in our forms, and I don't see an obvious way to support this through a custom form input.

https://react-jsonschema-form.readthedocs.io/en/latest/usage/arrays/#inline-checkboxes

@raymond-lam raymond-lam added the enhancement New feature or request label May 11, 2021
@ssmithereens
Copy link
Contributor Author

Actually I am wondering if this is a bug/typo?

'ui:option' vs. 'ui:options'

I will test this on a fork.

@ssmithereens
Copy link
Contributor Author

ssmithereens commented May 11, 2021

Changing 'ui:option' (not valid for react-jsonschema-form) to 'ui:options' does prevent the validation error and maybe opens up the possibility of supporting inline checkboxes as a custom form input if this is fixed.

@raymond-lam
Copy link
Collaborator

Actually I am wondering if this is a bug/typo?

'ui:option' vs. 'ui:options'

I will test this on a fork.

We appreciate it, thanks! Keep us posted and let us know if you have any questions

@raymond-lam
Copy link
Collaborator

Changing 'ui:option' (not valid for react-jsonschema-form) to 'ui:options' does prevent the validation error and maybe opens up the possibility of supporting inline checkboxes as a custom form input if this is fixed.

Oh, that's excellent. Will you be submitting a pull request to fix that bug?

@ssmithereens
Copy link
Contributor Author

@raymond-lam When I dug further I found a couple of other references to ui:option vs. ui:options in the codebase that probably also should be fixed. I hope to do a little more testing and then reopen the pull request shortly. Sorry for not clarifying that.

@ssmithereens ssmithereens changed the title Support for inline checkboxes Support for inline radio buttons May 21, 2021
@ssmithereens ssmithereens changed the title Support for inline radio buttons Support for inline radio buttons & checkboxes May 21, 2021
@ssmithereens ssmithereens changed the title Support for inline radio buttons & checkboxes Support for inline radio buttons & check boxes May 21, 2021
@georgeleeventures
Copy link

Is there any update here? I know you can specify the form element in the actual JSON code for checkmarks and radio buttons by hand, but the change be pushed so we can support this type of data?

@raymond-lam
Copy link
Collaborator

@georgeleeventures I'm sorry, but we don't have an update yet. We'll let you know when we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants