Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Form element's Description field data is lost after Input type edit #467

Open
andrew-s-titov opened this issue Jul 3, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrew-s-titov
Copy link

Form element's Description field data is lost in data schema after element edit if the last field updated is Input Type.
Checked on https://ginkgobioworks.github.io/react-json-schema-form-builder/

Steps to reproduce:

  1. create a Form element on Visual Form Builder or Pre-Configured Components tab
  2. fill the Description field
  3. go to Edit Schema tab to make sure there's a description prop in data schema (under property key)
  4. go back to the tab with the created Form element
  5. change element's Input Type field, do not "touch" any other element's fields
  6. go to Edit Schema tab

Actual result:

  • no description prop in data schema (field's data is silently erased)
  • no Description data after returning back to Visual Form Builder or Pre-Configured Components where the element was created

Expected result:

  • Description field data and description prop in data schema stays the same as before edit as there were no changes for it.
@raymond-lam raymond-lam added bug Something isn't working good first issue Good for newcomers labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants