Typescript template literal types causing an unexpected highlighting

[9oelM]

I wanted to open an issue but I'm not really sure if I could open an issue directly after reading the guideline, so i'm just posting it here. Also checked if there are existing issues/discussions/PRs - whatnot.

Since [email protected], it started supporting template literal types and I've become a lover of it.

And it seems that it breaks(?) highlighting of the file, like this:

You can have a look at the code here, or just write the code yourself and test it out too because it's very easy to produce. The code just needs to contain a template literal type and some more codes below it.

You can see that before the template literal type appears, the highlighting goes ok, but as soon as it reaches the block with it, it seems to have that plain sky blue color for all of the codes.

So.. I guess it's something to be fixed?

[9oelM]

Oh. I think I need to report it to https://github.com/Microsoft/TypeScript-TmLanguage!

[lildude]

Normally that would be the place and is for most consumers of Linguist, but not GitHub. GitHub actually overrides Linguist and uses the tree-sitter grammar from https://github.com/tree-sitter/tree-sitter-typescript for TypeScript's syntax highlighting.

You can see the Microsoft grammar used by Linguist does appear to correctly handle your file when you view it using the grammar tester (doesn't work for tree-sitter grammars) here

[lildude]

Looks like there's already an issue for it tree-sitter/tree-sitter-typescript#136 😄

[9oelM]

wooh yes. thank you for the pointer!