Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention how to handle GitHub Container Registry when using gh actions-importer configure #34236

Closed
1 task done
jsoref opened this issue Aug 7, 2024 · 9 comments
Closed
1 task done
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review SME reviewed An SME has reviewed this issue/PR

Comments

@jsoref
Copy link
Contributor

jsoref commented Aug 7, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/migrating-from-circleci-with-github-actions-importer#configuring-credentials

What part(s) of the article would you like to see updated?

There's a block that suggests the experience will look like this:

$ gh actions-importer configure
✔ Which CI providers are you configuring?: CircleCI
Enter the following values (leave empty to omit):
✔ Personal access token for GitHub: ***************
✔ Base url of the GitHub instance: https://github.com
✔ Personal access token for CircleCI: ********************
✔ Base url of the CircleCI instance: https://circleci.com
✔ CircleCI organization name: mycircleciorganization
Environment variables successfully updated.

When I ran it, I saw something closer to this:

% gh actions-importer configure
✔ Which CI providers are you configuring?: CircleCI
Enter the following values (leave empty to omit):
✔ GitHub handle used to authenticate with the GitHub Container Registry:
✔ Personal access token to authenticate with the GitHub Container Registry:
✔ Personal access token for GitHub:
✔ Base url of the GitHub instance: https://github.com
✔ Personal access token for CircleCI:
✔ Base url of the CircleCI instance: https://circleci.com
✔ CircleCI organization name: mycircleciorganization
Environment variables successfully updated.

There's a section before that block that talks about each of the questions and how to prepare answers for them, it includes:

Create a GitHub personal access token (classic). For more information, see "Managing your personal access tokens."

Your token must have the workflow scope.

It should have a step for setting up a GHCR credential too.

Additional information

No response

@jsoref jsoref added the content This issue or pull request belongs to the Docs Content team label Aug 7, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 7, 2024
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 7, 2024
@nguyenalex836
Copy link
Contributor

@jsoref Thanks for opening an issue! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 added the needs SME This proposal needs review from a subject matter expert label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@jsoref Thank you for your patience while our SME team reviewed! 💛

One of our SMEs tried running the configure command but came up with different results:

☁  gh-gei [github-api-upload] gh actions-importer configure
✔ Which CI providers are you configuring?: CircleCI
Enter the following values (leave empty to omit):
✔ Personal access token for GitHub: ****
✔ Base url of the GitHub instance: https://github.com/
✔ Personal access token for CircleCI: ****
✔ Base url of the CircleCI instance: https://circleci.com/
✔ CircleCI organization name: test
Environment variables successfully updated.

They were unable to find the GitHub handle used to authenticate with the GitHub Container Registry reference in our CLI codebase either - would you be able to provide additional info on the origin of that reference?

@nguyenalex836 nguyenalex836 added more-information-needed More information is needed to complete review SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 26, 2024
@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Oct 10, 2024
Copy link
Contributor

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. See this blog post on bug reports and the importance of repro steps for more information about the kind of information that may be helpful.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@jsoref
Copy link
Contributor Author

jsoref commented Oct 10, 2024

@jsoref
Copy link
Contributor Author

jsoref commented Oct 10, 2024

Fwiw, here's the output of gh actions-importer version:

gh actions-importer version
gh version 2.57.0 (2024-09-16)
gh actions-importer	github/gh-actions-importer	v1.0.1
actions-importer/cli	v1.3.22130

@jsoref
Copy link
Contributor Author

jsoref commented Oct 10, 2024

So, here's a proper link to the code:
https://github.com/github/gh-actions-importer/blob/c3865c04bc43d7ea00d32fe98d32597c2d81142b/src/ActionsImporter/Constants.cs#L9

This appears to be a case of a tool not having a provision to warn users that it's woefully out of date (v1.0.1). The current version is apparently v1.3.6.

@nguyenalex836
Copy link
Contributor

@jsoref Bot poked 💛 Thank you for the additional info! I'll have the SME team review and provide their insight.

@nguyenalex836 nguyenalex836 reopened this Oct 10, 2024
@github-actions github-actions bot added triage Do not begin working on this issue until triaged by the team and removed stale There is no recent activity on this issue or pull request labels Oct 10, 2024
@nguyenalex836 nguyenalex836 removed the triage Do not begin working on this issue until triaged by the team label Oct 10, 2024
@nguyenalex836
Copy link
Contributor

@jsoref 👋 Hello! Our SMEs reviewed again, your guess was correct - running the current version of the tool produces a different than the what you initially noted.

This appears to be a case of a tool not having a provision to warn users that it's woefully out of date (v1.0.1).

We'll raise this with the relevant owning team to see what our options are for addressing 💛 Thanks again for raising a flag on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team more-information-needed More information is needed to complete review SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

No branches or pull requests

3 participants
@jsoref @nguyenalex836 and others