Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] pull-request-review-comment.user should be nullable-simple-user #4266

Open
mnahkies opened this issue Nov 10, 2024 · 0 comments

Comments

@mnahkies
Copy link

Schema Inaccuracy

the user property of pull-request-review-comment should be #/components/schemas/nullable-simple-user instead of #/components/schemas/simple-user - same as on pull-request-review

I suspect the same is true for pull-request, presumably this occurs when a user is deleted. It seems probable that most, if not all usages of simple-user should be replaced with nullable-simple-user

Expected

Any user properties that are nulled when the associated user is deleted should be nullable-simple-user

Reproduction Steps

(I didn't make a note of the exact resource I observed this on, but will update when I next find one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants