Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes multiple issues #245

Open
m-bakoulis opened this issue Dec 12, 2024 · 4 comments
Open

Themes multiple issues #245

m-bakoulis opened this issue Dec 12, 2024 · 4 comments

Comments

@m-bakoulis
Copy link

Hi @givanz I am trying to duplicate and modify some themes and these are the issues I am addressing.

  1. If I choose to modify a theme using the Duplicate button, I am not able to use the revisions feature since the backup folder seems to be missing from the duplicated structure.
  2. If I move around a section from the sections menu then the save does not becomes active.
  3. If I move around a section using the Move Element Down/Up button then I am able to save the result but then the Javascript libraries are stopping to work. For example the scroll animations are not working. For example on the Apsho theme the screenshots and the comments are not responding.
  4. When you select the Activate theme button you get some html code on related success notification.
    Screenshot 2024-12-12 101314

Thanks in advance and thank you for that great platform.

@givanz
Copy link
Owner

givanz commented Dec 13, 2024

Hi

Thank you for bug reports, they are fixed in latest.zip

  1. I changed duplicated code to copy backup folder also to avoid this issue, changed file admin/controller/theme/themes.php
  2. Now save button is enabled when sections are reordered changed file public/js/vvvebjs/builder.js
  3. Fixed activate theme notification text, changed file admin/template/notifications.tpl, clear cache is needed.

Can you please provide more details for 3, I moved sections with up/downs buttons but I'm unable to break animations, tried on homepage on Apsho theme.

@m-bakoulis
Copy link
Author

Hi @givanz and many thanks for your quick rensponce.
Here are the steps I just tried (I have not updated yet to the latest.zip since I reported this).

  • While I am in the editor I went to the "screenshots" section and I moved this section after the "faq" section.
  • I saved the changes and I viewed the in a new tab.
  • I scrolled to "screenshots section and the section is not properly formated (Screenshots are out of the cellphone frame) anymore and changing screenshots is not working. Please refer to the screenshot.
    Screenshot 2024-12-18 123824

@givanz
Copy link
Owner

givanz commented Jan 8, 2025

Thanks for the screenshot, this was caused by slider js code not initializing after the new section was added.

I added code to initialize the slider after the section is inserted in the last theme update, changed files inside /js folder.

@m-bakoulis
Copy link
Author

Great news, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants