-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firenvim conflict with Github "Review changes" text box #1586
Comments
Hi, thanks for the report! This doesn't happen with Firefox on debian, I'll try Chrome in a few hours. |
I have the following vim configuration that might be relevant:
I'll retry with that disabled. Update: Disabling that does not have any effect on the behavior. |
Can repro on Chrome, will dig in :) |
Workaround: let g:firenvim_config = {
\ 'localSettings': {
\ 'github.com': {
\ 'selector': 'textarea:not(#pull_request_review_body)',
\ }
\ }
\ } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What I tried to do
With firenvim enabled,I cannot enter text into the "Finish your review" text box when reviewing GitHub pull requests:
Attempting to activate the "Leave a comment" field by clicking in briefly flashes the border of the field, but the field never becomes active and I am unable to enter text. If I disable firenvim in the tab it works as expected.
This is the only text field (on GitHub or elsewhere) for which I have encountered this problem.
The text was updated successfully, but these errors were encountered: