Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firenvim conflict with Github "Review changes" text box #1586

Open
larsks opened this issue Feb 13, 2024 · 4 comments
Open

Firenvim conflict with Github "Review changes" text box #1586

larsks opened this issue Feb 13, 2024 · 4 comments

Comments

@larsks
Copy link
Contributor

larsks commented Feb 13, 2024

  • OS Version: Fedora 38
  • Browser Version: Chrome 121.0.6167.160
  • Browser Addon Version: 0.2.15
  • Neovim Plugin Version: 8c6c00a

What I tried to do

With firenvim enabled,I cannot enter text into the "Finish your review" text box when reviewing GitHub pull requests:

Screenshot from 2024-02-13 16-36-39

Attempting to activate the "Leave a comment" field by clicking in briefly flashes the border of the field, but the field never becomes active and I am unable to enter text. If I disable firenvim in the tab it works as expected.

This is the only text field (on GitHub or elsewhere) for which I have encountered this problem.

@glacambre
Copy link
Owner

Hi, thanks for the report! This doesn't happen with Firefox on debian, I'll try Chrome in a few hours.

@larsks
Copy link
Contributor Author

larsks commented Feb 14, 2024

I have the following vim configuration that might be relevant:

if exists('g:started_by_firenvim')
    function! AdjustMinimumLines(timer)
            if &lines < 10
                set lines=10
            endif
    endfunction

    function! OnUIEnter(event) abort
        if 'Firenvim' ==# get(get(nvim_get_chan_info(a:event.chan), 'client', {}), 'name', '')
            set laststatus=0
	    set guifont=Iosevka\ Fixed\ Curly\ Light:h14

            call timer_start(100, function("AdjustMinimumLines"))
        endif
    endfunction

    autocmd UIEnter * call OnUIEnter(deepcopy(v:event))
endif

I'll retry with that disabled.

Update: Disabling that does not have any effect on the behavior.

@glacambre
Copy link
Owner

Can repro on Chrome, will dig in :)

@glacambre
Copy link
Owner

Workaround:

let g:firenvim_config = {
    \ 'localSettings': {
        \ 'github.com': {
            \ 'selector': 'textarea:not(#pull_request_review_body)',
        \ }
    \ }
\ }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants