Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Inline Japanese Input in Firenvim #1642

Open
mtanda opened this issue Oct 6, 2024 · 0 comments · May be fixed by #1643
Open

Add Support for Inline Japanese Input in Firenvim #1642

mtanda opened this issue Oct 6, 2024 · 0 comments · May be fixed by #1643

Comments

@mtanda
Copy link

mtanda commented Oct 6, 2024

Hello!

First of all, I’d like to express my gratitude for creating such an incredibly useful tool. I recently started using Firenvim, and it has been extremely helpful for my workflow. I also appreciate that Japanese input is supported, which has made things much easier.

However, there’s a small improvement I’d like to suggest. While typing in Japanese, the text being input doesn’t appear "inline in the actual textarea" where it is meant to be entered. In my environment, the Japanese input system shows the text near the mouse cursor, but since it’s displayed slightly away from where I am typing, I find myself prone to making typing mistakes.

Therefore, I’d like to request support for "inline input." Similar requests have been raised in other tools, such as WezTerm, and they've successfully implemented it, as shown here: wez/wezterm#3411

I tried making changes to support inline input myself, and it seems to work. If possible, could you please review my implementation?

Thank you once again for your hard work!

@mtanda mtanda linked a pull request Oct 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant