Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set iframe background color on neovim's default_colors_set (#1637) #1638

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Set iframe background color on neovim's default_colors_set (#1637) #1638

merged 3 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Update package.json/package-lock.jon

    @glacambre
    glacambre committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    25d6278 View commit details
    Browse the repository at this point in the history

  2. Set iframe background color on neovim's default_colors_set (#1637) 

    Issue #1637 reports that resizing the underlying textarea of a Firenvim
iframe can result in flashes of color. This can be particularly visible
when using Firenvim with a dark colorscheme on Github in dark mode.

The reason for these flashes of color is that when resizing, the iframe
gets resized first and the Neovim canvas gets resized second, between
these two moments, the iframe's background color can become visible if
the CSS colorscheme of the iframe and of the website do not match.

We fix this by ensuring that the iframe's background color is set to the
background color of the Neovim colorscheme. This breaks the ability of
the iframe to turn transparent when unfocused (the iframe gets dimmed
instead), but given that multiple users complained about this feature,
it may not be such a bad change.

Closes #1637.
    @glacambre
    glacambre committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ee47cad View commit details
    Browse the repository at this point in the history

  3. test.yml: upgrade to upload-artifact@v4 action

    @glacambre
    glacambre committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fcfc812 View commit details
    Browse the repository at this point in the history