You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just started using this Action and had a quick look at the source code to see how it works. Based on that (and not on my experience with the Action so far) I have one suggestion: instead of terminating the Action when there is an error or an unexpected error, continue when an error occurs and report all the errors that occurred when the Action finished.
I'm not a Go expert but I would suggested doing that by returning []error in forEachArtifact and appending any errors from iter (and possibly ListWorkflowRuns?) to a slice that is returned when the last page is reached.
I do think there should be a separate way to handle the error reported in #2 to ensure the Action stops as soon as the rate limit is reached.
As an aside, based on reading the code it seems that return-on-stop is never executed because iter only ever returns true if it also returns an error. This may be simplifed by returning just an error (instead of both a boolean and an error).
The text was updated successfully, but these errors were encountered:
I just started using this Action and had a quick look at the source code to see how it works. Based on that (and not on my experience with the Action so far) I have one suggestion: instead of terminating the Action when there is an error or an unexpected error, continue when an error occurs and report all the errors that occurred when the Action finished.
I'm not a Go expert but I would suggested doing that by returning
[]error
inforEachArtifact
and appending any errors fromiter
(and possiblyListWorkflowRuns
?) to a slice that is returned when the last page is reached.I do think there should be a separate way to handle the error reported in #2 to ensure the Action stops as soon as the rate limit is reached.
As an aside, based on reading the code it seems that return-on-stop is never executed because
iter
only ever returns true if it also returns an error. This may be simplifed by returning just anerror
(instead of both aboolean
and anerror
).The text was updated successfully, but these errors were encountered: