Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete command which name contains '/' #198

Open
kgyrtkirk opened this issue Aug 2, 2017 · 3 comments
Open

Unable to delete command which name contains '/' #198

kgyrtkirk opened this issue Aug 2, 2017 · 3 comments

Comments

@kgyrtkirk
Copy link

I was experimenting with commands which were prefixes of eachother...

$ cat some.cmd | ssh alpha.cmd.io  :create u/a/b/c
Command u/a/b/c already exists
$ ssh alpha.cmd.io  :delete u/a/b/c
Command not found: u/a/b/c

altough these can be created...they are not callable currently.
It would be either good to:

  • prevent the creation of command which contains '/'
  • or support them...

I think it would be practical to not support commands which contains '/' in their name.

@progrium
Copy link
Contributor

progrium commented Aug 2, 2017

I agree it would be better to prevent creating them. Thanks for catching this!

@Omeryl
Copy link
Contributor

Omeryl commented Aug 27, 2017

@progrium should we have a whitelist of allowed characters, or just specifically block "/"?

@progrium
Copy link
Contributor

progrium commented Aug 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants