Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

over 200 definitions use semicolons where they should use commas. #901

Closed
fcbond opened this issue Feb 9, 2023 · 0 comments · Fixed by #923
Closed

over 200 definitions use semicolons where they should use commas. #901

fcbond opened this issue Feb 9, 2023 · 0 comments · Fixed by #923
Milestone

Comments

@fcbond
Copy link
Member

fcbond commented Feb 9, 2023

Affected synsets
e.g. oewn-08876674-n "British Empire"

There is a discussion in own-pt/glosstag/issues/34, which includes a complete list including synset ID (PWN30) original (from PWN30) and suggested changes (in XML).

Proposed changes
a former empire consisting of Great Britain and all the territories under its control; reached its greatest extent at the end of World War I; it included the British Isles, British West Indies, Canada, British Guiana; British West Africa, British East Africa, India, Australia, New Zealand; "the sun never sets on the British Empire"

a former empire consisting of Great Britain and all the territories under its control; reached its greatest extent at the end of World War I; it included the British Isles, British West Indies, Canada, British Guiana, British West Africa, British East Africa, India, Australia, New Zealand; "the sun never sets on the British Empire"

Semi-colon after British Guiana changed to comma.

Motivation
Semicolons should be used to separate clauses, not constituents in lists. This makes the definitions grammatical!

Note that I have made a couple of other very small changes to the definitions, but nothing major (and there are probably more things that could be fixed that I ignored: just focusing on punctuation here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants