Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect data32/data64 type in clap_audio_buffer #29

Open
ilmai opened this issue Feb 11, 2024 · 1 comment
Open

Incorrect data32/data64 type in clap_audio_buffer #29

ilmai opened this issue Feb 11, 2024 · 1 comment

Comments

@ilmai
Copy link

ilmai commented Feb 11, 2024

In audio-buffer.h, data32 and data64 have types float** and double**, respectively. In clap-sys, these translate to *const *const f32 and *const *const f64. They should be *mut *mut instead to match the C API.

@glowcoil
Copy link
Owner

You're right, and it would be good to fix this going forward. I'm not sure why the pointers were *const in the first place.

It is worth pointing out that this makes no difference in terms of either FFI correctness or Rust safety, so there's no risk of this causing issues for existing code and the fix would be purely for clarity's sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants