Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in README.markdown #381

Open
mikost opened this issue Oct 11, 2023 · 1 comment
Open

Error in README.markdown #381

mikost opened this issue Oct 11, 2023 · 1 comment
Assignees

Comments

@mikost
Copy link

mikost commented Oct 11, 2023

version of diffson: 4.1.1

In README.markdown, section "Basic Usage", the result of patch[Try](json1) is shown as:

{
  "d":false,
  "c":"test2",
  "a":6
}

and the text says "... which we can easily verify is the same as json2 modulo reordering of fields".

However, json2 was actually:

{
  "a": 6,
  "c": ["test2", "plop"],
  "d": false
}

which is not the same as the purported patch result (the "c" fields differ).

@satabin
Copy link
Member

satabin commented Oct 11, 2023

Indeed this needs to be fixed. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants