Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible defaults for permissions (role names) #188

Open
cedricwaxwing opened this issue Jan 16, 2023 · 2 comments
Open

Sensible defaults for permissions (role names) #188

cedricwaxwing opened this issue Jan 16, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cedricwaxwing
Copy link
Collaborator

EX:
Contributor
Admin
Custom, etc

@cedricwaxwing cedricwaxwing added the enhancement New feature or request label Jan 16, 2023
@cedricwaxwing
Copy link
Collaborator Author

Thinking a bit more on this one, and I'm wondering if we should change "Permissions" to "Members" or something, since it's showing each member. Then, when setting permissions for the member, there are 3 or 4 options:

  • Contributor
  • Editor?
  • Admin
  • Create Custom

If custom is selected, the entire array of checkboxes is visible, along with a "role name" field so you can save it and reuse it.

We can include a small description for each role above so that the user knows what's possible for each.


In addition to this, I think it would also be nice to add the concept of a "Display Name" when adding a new member. That way it's easy to validate who is who and who has what permissions (vs looking at different wallet addresses)

I've mocked something up in #202 , but it's currently just commented out. It would look something like this (though the user-specific custom avatars are not available, yet)
image

@cedricwaxwing cedricwaxwing added this to the Medium Priority milestone Jan 25, 2023
@auryn-macmillan
Copy link
Member

Yeah, I think display names are a good idea. It kind of hints at #172, which I think we decided is out of scope for now. If we do add display names, we should be conscious of how this might interact/be used as part of #172 in future.

Otherwise, yeah I agree that "permissions" could be changed to "members" or "team", with each members role/permissions displayed alongside their address/display name. This begs the question of how to handle/display custom permission configurations.

@cedricwaxwing cedricwaxwing removed this from the Medium Priority milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants