Fix auto-scrolling issue when adding new lines #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cedricwaxwing
approved these changes
Jul 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
closes #230
This PR addresses an odd UX behavior in the text editor. Before the fix, when a user was adding new lines at the bottom of the page, the editor didn't automatically scroll to the new line. Instead, it waited until the user began typing. This issue also affected pasted text, where the editor did not respond at all.
Changes include:
useEffecthook which updates the editor state to focus on the new line once it's created.scrollIntoViewIfNeededto ensure that the new line is brought into view when added, even if it's created by pasting text from the clipboard.With these changes, the editor should now auto-scroll to a new line when it's created, improving the user experience.
Testing
Screen.Recording.2023-07-20.at.1.05.25.PM.mov