-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance UI for User-Configured Pinning Service in Tabula #248
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliopavila and @cedricwaxwing; here are my comments:
- I thought we decided to run a pinning service ourselves (Gnosis Guild) for the first option instead of relying on a public one. So that the first option would be something like "Use the Pinning Service hosted by us...".
- Shouldn't the "warning" be displayed in a modal that will pop up when the user clicks "Publish", if they have not made the choice before? Also, I am not sure if it's appropriate to use a warning here (it's just a step of the prosses, as long as it's not selected before and no custom pinning service is configurated).
- Shouldn't each of the options be selectable, like with a radio button or something? Because they need to pick one of them.
- Also, we should probably store the selection in locale storage so we do not prompt them again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how I think it should work:
I think we should remove the "Update Store Configuration" button from the drop-down.
The modal should only be displayed when the user clicks "Publish", and no pinning service option is previously selected.
The "Choose store option" modal should probably be renamed to "How do you want to make your articles available?" or something like that.
If the user wants to edit their pinning service setup later, it should happen under "Setup Pinning Service", as was the case before this PR (just with the two new options added to the drop-down many, as described below).
We should add the options "None (post content on-chain)" and "Public Tablua pinning service" to the pinning service drop-down in the "Setup Pinning Service"-modal.
The button in the modal should probably say "Continue", and it should probably not use a yellow box around the text in the modal.
If the user selects our pinning service option or "Post article on-chain", we must automatically configure the pinning service when the user clicks continue (this is the same thing as what is displayed in the dropdown in the "Setup Pinning Service" modal). If the user selects the set up a pinning service alternative and clicks continue, we must display the "Setup Pinning Service" modal.
But anyway, I think @cedricwaxwing needs to take a look at this.
@manboy-eth @cedricwaxwing The last push contains the following improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just finished exploring the new changes.
Great work @juliopavila - this is such a big improvement in terms of the UX. 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @juliopavila 🚀
Description:
Closes #238 #246
This PR introduces several improvements and fixes around the handling of pinning services in Tabula. It aims to guide users more effectively based on their configuration and make the UI more informative and user-friendly.
Major Changes:
Introduced Pinning Configuration Modal:
Added Pinning Configuration and Pinning Selection Components:
Refactored EditorRichText Component:
Code Cleanup and UI Enhancements:
Refactored Wallet View and useIpfs Hooks:
Updated usePoster Hook:
createArticle
andupdateArticle
methods to adapt to the new pinning service configurations.Detailed File Changes:
Added new components:
PinningConfiguration.tsx
PinningSelection.tsx
Modified existing components:
EditorRichText.tsx
UploadFile.tsx
ArticleSidebar.tsx
CreateArticleView.tsx
WalletView.tsx
useIpfs.ts
usePoster.ts
pinning.ts
Removed old code from the following files:
EditorInlineText.tsx
PublicationAvatar.tsx
turndown.ts
PinningAlert.tsx
SetupIpfsView.tsx
Modified
package.json
:Testing Performed
To ensure that the pinning configuration works as expected and that users can interact with the various cases, the following tests have been performed:
Test Case 1:
Test Case 2:
Test Case 3:
Screenshots:
Pinning Configuration Modal
Disabled Image component of the editor when the pinning service is not set up
Context:
These changes are aimed at guiding users appropriately based on their configuration and making the UI more informative and user-friendly. The implemented solution has been discussed here.
Please refer to the linked threads for further context.