Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block picker keyboard navigation is a little buggy #271

Open
auryn-macmillan opened this issue Oct 17, 2023 · 2 comments
Open

Block picker keyboard navigation is a little buggy #271

auryn-macmillan opened this issue Oct 17, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@auryn-macmillan
Copy link
Member

Describe the bug
There are three related issues with block picker keyboard navigation:

  1. [up] and [down] navigate the block picker, while [left] and [right] move the cursor in the document.
  2. navigating below the fold in the block picker does not scroll the block picker window; one loses visibility on which block-type is selected and must use the mouse to scroll the view down.
  3. text in the block picker is not needed.

To Reproduce
Steps to reproduce the behavior:

  1. start a line with [/] and then press the arrow keys

Expected behavior

  1. all four arrow keys should navigate in the block picker
  2. the block picker should scroll automatically to keep the cursor visible
  3. we should remove the text from the various options in the block picker, these could perhaps be replaced with hover text.
@auryn-macmillan auryn-macmillan added the bug Something isn't working label Oct 17, 2023
@auryn-macmillan auryn-macmillan self-assigned this Oct 17, 2023
@cedricwaxwing
Copy link
Collaborator

@auryn-macmillan Unless I'm misunderstanding this, I'm not necessarily convinced that the text should be removed from the options. Is this just a space saver for the menu, or do you have other concerns?

@auryn-macmillan
Copy link
Member Author

I think if we keep the text, we should stick to one column and ensure each item is limited to one row.

e.g. Tabula

Screencast.from.10-30-2023.10.51.57.AM.webm

e.g. Notion

image

e.g. Skiff

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants