Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no pinning service is configured, display the IPFS hash for images #50

Closed
Tracked by #184
asgeir-s opened this issue Apr 27, 2022 · 3 comments
Closed
Tracked by #184
Assignees
Labels
app enhancement New feature or request

Comments

@asgeir-s
Copy link
Contributor

If a user has not configured a pinning service, we should display a warning something like:
"Here is the hash of the image you uploaded, since you have not configured a pinning service you need to pin this hash yourself in order for the image to load for other users." and display the hash.

The easiest is probably a modal, @cedricwaxwing?

@cedricwaxwing
Copy link
Collaborator

Yeah a modal makes sense here. Is there some way we can validate when the hash is pinned? Ideally we just disabled publishing until this is done (if I'm understanding this correctly).

@asgeir-s
Copy link
Contributor Author

asgeir-s commented May 4, 2022

Yeah a modal makes sense here. Is there some way we can validate when the hash is pinned? Ideally we just disabled publishing until this is done (if I'm understanding this correctly).

I don't think that's something we can easily or should validate since it's not a strict requirement. It's just that the images they upload might not be retrievable, however, all text content will be available. So I don't think we should disable publishing. It's more like "If you want to make sure that your readers can see the image you uploaded, then pin this hash manually".

We should probably also prompt users to add a Pinning Service again in the modal.

@auryn-macmillan auryn-macmillan added this to the Next release milestone May 20, 2022
@auryn-macmillan auryn-macmillan added the enhancement New feature or request label Jul 29, 2022
@cedricwaxwing cedricwaxwing modified the milestones: Next release, Medium Priority Jan 16, 2023
@cedricwaxwing cedricwaxwing removed this from the Medium Priority milestone Jul 18, 2023
@juliopavila
Copy link
Collaborator

juliopavila commented Sep 14, 2023

handled #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants