-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 support #21
Comments
Hi Steve, In principle yes, why not? How do you see this happening, do we try to merge the two repos, and if yes, how? Also, I tried to look at your commit that added ESP32 support, to see what you did, but it says it contains 133 (!) changed files: Any chance you can split the esp32 support from the rest of the updates into a separate commit? Cheers, |
Yes, you're right, my bad: I went from v2.41 of Henning Karlsen's library to v2.83 and ESP32 support in one go. As far as I can tell, all of the changes you need for 8-bit support are here: https://github.com/jscrane/UTFT-Energia/blob/master/hardware/esp32/HW_ESP32.h (You should have all of the other infrastructure in your work already.) I don't see how we can merge repositories easily at this point however :-( |
Ok, here's what I will do: I'll update first mine to v2.83 (I'm one behind, v2.82) and then I'll do a diff with yours and I'll come back to you with a proposal. |
Hi,
I've just added 8-bit support for ESP32 here: https://github.com/jscrane/UTFT-Energia
It might be good to combine our efforts? WDYT?
Cheers,
Steve
The text was updated successfully, but these errors were encountered: