Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit() function can not distinguish whether the transaction has been sent #1225

Closed
syuanyuan708 opened this issue Jun 21, 2021 · 1 comment

Comments

@syuanyuan708
Copy link

Issue description

when I call func (tx *mysqlTx) Commit() (err error) ,if connection has problem it return an ErrInvalidConn
commit

but if current connection is fine it call exec
exec

and in exec it call readResultSetHeaderPacket after the transaction sent to db successfully, and readResultSetHeaderPacket call readPacket() and it also may lead to ErrInvalidConn
readpackets

thus I can't distinguish whether the transaction has been sent, it lead to one transaction sent twice and data not correct. Is it possible to add a new error to distinguish this two cases?

Example code

If possible, please enter some example code here to reproduce the issue.

err = tx.Commit(ctx)
if err != nil {
xlog.Errorf(ctx, "%s commit transaction failed, table:%v err:%v", fun, table, err) ...

Error log

***err:invalid connection 

Configuration

Driver version (or git SHA):

*Go version: go1.12 linux/amd64

*Server version: tidb

*Server OS: redhat7.2

@shogo82148
Copy link
Contributor

duplicated by #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants