Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ErrBadConn #1582

Open
methane opened this issue May 16, 2024 · 0 comments · May be fixed by #1583
Open

Improve ErrBadConn #1582

methane opened this issue May 16, 2024 · 0 comments · May be fixed by #1583

Comments

@methane
Copy link
Member

methane commented May 16, 2024

We have dropped old go versions. So we can improve how ErrBadConn handled.

Since database/sql uses IsValid() and ResetSession() to check connection, we can return i/o errors without translating them into ErrBadConn.

We should remove errBadConnNoWrite too.
@methane methane linked a pull request May 16, 2024 that will close this issue
Open
5 tasks
@coderabbitai coderabbitai bot mentioned this issue Jun 14, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove errBadConnNoWrite and markBadConn methane/mysql
1 participant
@methane