Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fontscan] Provide precise Location in FontMap.AddFace #112

Closed
benoitkugler opened this issue Nov 24, 2023 · 1 comment · Fixed by #119
Closed

[fontscan] Provide precise Location in FontMap.AddFace #112

benoitkugler opened this issue Nov 24, 2023 · 1 comment · Fixed by #119

Comments

@benoitkugler
Copy link
Contributor

I use FontMap.AddFace to have control about the description registered with a font, but I would also control the file identifier.
That is, I would like to also pass a Location. For now, the package generate a synthetic file name with
out.Location.File = fmt.Sprintf("%v", md) (md being the font description provided by the caller).

Would you be OK to change the signature to AddFace(face font.Face, id Location, md meta.Description) ?

The previous behavior could be easily obtained with
AddFace(face font.Face, Location{File: fmt.Sprintf("%v", md)}, md meta.Description)

Pinging @whereswaldon as code author

@whereswaldon
Copy link
Member

I have no objection; do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants