Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate instances of fold_right #1536

Open
michael-schwarz opened this issue Jul 6, 2024 · 0 comments
Open

Investigate instances of fold_right #1536

michael-schwarz opened this issue Jul 6, 2024 · 0 comments
Labels
cleanup Refactoring, clean-up good first issue

Comments

@michael-schwarz
Copy link
Member

We have ~30 calls to List.fold_right in our code and it seems at least for some of them they do the same thing as a fold_left (accumulator is a hash set, or only caller turns returned list into a set-like thing) and there's no particular reason to do things in a specific order.
We should go through them and replace them where appropriate.

@michael-schwarz michael-schwarz added the cleanup Refactoring, clean-up label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up good first issue
Projects
None yet
Development

No branches or pull requests

2 participants