Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ERROR (both branches dead)" verdict for SV-COMP #1579

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Sep 27, 2024

Closes #1576.

@sim642 sim642 added bug unsound sv-comp SV-COMP (analyses, results), witnesses labels Sep 27, 2024
@sim642 sim642 added this to the SV-COMP 2025 milestone Sep 27, 2024
@michael-schwarz
Copy link
Member

Before merging this we should verify that it is not just because the condition transfer functions are quite strong that we end up with this warning because the predecessor is in fact unreachable.

@sim642
Copy link
Member Author

sim642 commented Sep 27, 2024

We should have this behavior either way independently of any particular task if we want to be serious about soundness.
If the both branches dead warning is triggered too generously, that's a separate precision problem for that.

Copy link
Member

@michael-schwarz michael-schwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should keep a keen lookout for the instances of this.

I'm still wondering if if we can devise some way to not raise this when it's simply to imprecision of domains (Maybe don't raise it for Polyhedra at all now?)

@sim642
Copy link
Member Author

sim642 commented Sep 30, 2024

I tried forcing Apron to somehow reduce integer constraints in #1585 to avoid the spurious cautiousness but none of it is particularly nice.
We should see from (our own) pre-runs how often this actually comes up on sv-benchmarks and then decide what to do about these.

@sim642 sim642 merged commit 815336e into master Sep 30, 2024
21 checks passed
@sim642 sim642 deleted the issue-1576 branch September 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sv-comp SV-COMP (analyses, results), witnesses unsound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR verdict for both branches dead in SV-COMP
2 participants