Support imaxabs for SV-COMP
#1519
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for sv-benchmarks Juliet no-overflow tasks involving sqrt. We used this at SV-COMP 2024, before the option existed.
michael-schwarz
approved these changes
Jun 25, 2024
| @@ -785,7 +785,8 @@ struct | |||
| | TFloat (fk, _), FLongDouble | |||
| | TFloat (FDouble as fk, _), FDouble | |||
| | TFloat (FFloat as fk, _), FFloat -> inv_exp (Float (FD.cast_to fk c)) e st | |||
| | _ -> fallback (fun () -> Pretty.text "CastE: incompatible types") st) | |||
| | TInt (ik, _), _ -> inv_exp (Int (FD.to_int ik c)) e st (* TODO: is this cast refinement correct? *) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #1254 to support
imaxabson theintmax_ttype, which some Juliet tasks in SV-COMP use.Changes
Actually verifying those Juliet tasks required a bit more changes:
intmax_tis looked up from thetypedefin the program. So this can bypass make sizes of primitive types configurable with current machine as default #54.ana.float.evaluate_math_functionsis enabled in svcomp24 and svcomp confs. We used the C stubs to evaluatesqrtand friends in SV-COMP 2024, but More precise abstractions of trigonometric functions using c-stubs #1277 added this option, which is off by default. So right now we couldn't even solve the similar tasks on smaller types that we could verify at SV-COMP 2024. I don't know if this will be a problem for soundness in SV-COMP. If so, then we'll need some non-stub implementation of floating pointsqrtto solve these tasks, of which there is a lot of.BaseInvariant. I don't know if this is correct because previously only various float-float casts were supported and everything else was considered "incompatible types". It's not clear whether these are supposed to be impossible in the AST according to the standard or just were unsupported in the initial implementation.TODO