Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to skip rows that fail to unmarshal #246

Open
LukasDeco opened this issue Mar 9, 2023 · 2 comments
Open

Option to skip rows that fail to unmarshal #246

LukasDeco opened this issue Mar 9, 2023 · 2 comments

Comments

@LukasDeco
Copy link

I noticed that when you have a custom type with custom converter using UnmarshalCSV, if it has an error, the Reader bails out from reading the rest of the rows, and they all become nil. Instead of bailing out, could we have an option where the reader will just return that row as nil but then continue on? So that way it doesn't nil-out valid rows. Let me know if that doesn't make sense.
@LukasDeco
Copy link
Author

I would be interested in submitting an MR for this potentially.

@DrBlury
Copy link

DrBlury commented Jul 28, 2023

@LukasDeco could you provide a PR/Fork that fixes this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukasDeco @DrBlury