Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go vet warnings #66

Open
chrisaxiom opened this issue Jun 30, 2016 · 0 comments
Open

go vet warnings #66

chrisaxiom opened this issue Jun 30, 2016 · 0 comments

Comments

@chrisaxiom
Copy link

Hello!

Thank you for the great library - we use it daily. Recently we ran into a small issue.

This is a go vet bug in my opinion, but until that is addressed, people running go vet on their code (including /vendor folder) will run into the following warning when using the Error handler:

arg (*Context).Error in Error call is a function value, not a function call

You can also see this by running go vet in the root of this project. I think go vet is incorrectly picking up keywords here (error, panic, etc) and incorrectly reporting that warning, as renaming Error to Panic also fails, where OnError passes (for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant